Skip to content

[FrameworkBundle] Don't get() private services from debug:router #23366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jul 3, 2017

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Fixes

php.INFO: User Deprecated: Requesting the "controller_name_converter" private service is deprecated since Symfony 3.2 and won't be supported anymore in Symfony 4.0. {"exception":"[object] (Symfony\Component\Debug\Exception\ContextErrorException(code: 0): User Deprecated: Requesting the "controller_name_converter" private service is deprecated since Symfony 3.2 and won't be supported anymore in Symfony 4.0. at /tmp/name_parser/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Container.php:260)"}

@chalasr chalasr force-pushed the command-get-privates branch from 11abdb7 to 08a6178 Compare July 3, 2017 23:09
@fabpot
Copy link
Member

fabpot commented Jul 4, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 08a6178 into symfony:3.2 Jul 4, 2017
fabpot added a commit that referenced this pull request Jul 4, 2017
…router (chalasr)

This PR was merged into the 3.2 branch.

Discussion
----------

[FrameworkBundle] Don't get() private services from debug:router

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fixes
> php.INFO: User Deprecated: Requesting the "controller_name_converter" private service is deprecated since Symfony 3.2 and won't be supported anymore in Symfony 4.0. {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\ContextErrorException(code: 0): User Deprecated: Requesting the \"controller_name_converter\" private service is deprecated since Symfony 3.2 and won't be supported anymore in Symfony 4.0. at /tmp/name_parser/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Container.php:260)"}

Commits
-------

08a6178 Don't access private services from container aware commands (deprecated)
This was referenced Jul 4, 2017
@chalasr chalasr deleted the command-get-privates branch July 4, 2017 07:45
fabpot added a commit that referenced this pull request Jul 4, 2017
…ebug:router (ogizanagi)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] 3.3: Don't get() private services from debug:router

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #23366 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Same as #23366 but another place exist in upper branches.

However, the original fix prevents using the proper name parser in case it was replaced 😕 .

Commits
-------

c75e486 [FrameworkBundle] 3.3: Don't get() private services from debug:router
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants