Skip to content

[Process] Remove enhanced Windows compatibility #23376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

maidmaid
Copy link
Contributor

@maidmaid maidmaid commented Jul 4, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets /
License MIT
Doc PR /

In 4.0, enhanced Windows compatibility is always enabled.

@nicolas-grekas
Copy link
Member

Can you also remove "getEnhanceSigchildCompatibility" please?

@fabpot
Copy link
Member

fabpot commented Jul 4, 2017

Thank you @maidmaid.

@fabpot fabpot merged commit 6033503 into symfony:master Jul 4, 2017
fabpot added a commit that referenced this pull request Jul 4, 2017
…aid)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[Process] Remove enhanced Windows compatibility

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

In 4.0, enhanced Windows compatibility is always enabled.

Commits
-------

6033503 Remove enhancement Windows compatibility
@maidmaid maidmaid deleted the process-4 branch July 4, 2017 12:07
fabpot added a commit that referenced this pull request Jul 5, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

Add some missing changelog/upgrade infos

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23387 #23376 #23363
| License       | MIT
| Doc PR        | /

Oops, some PRs have been merged without changelog/upgrade infos...

Commits
-------

19c6a6f Add some meta infos
nicolas-grekas added a commit that referenced this pull request Jul 12, 2017
…maid)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[Process] Remove enhanced sigchild compatibility

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23376 (comment), #22836 (comment)
| License       | MIT
| Doc PR        | /

In 4.0, enhanced sigchild compatibility is always enabled.

Commits
-------

1aa7d68 Remove enhance sigchild compatibility
symfony-splitter pushed a commit to symfony/process that referenced this pull request Jul 12, 2017
…maid)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[Process] Remove enhanced sigchild compatibility

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony#23376 (comment), symfony/symfony#22836 (comment)
| License       | MIT
| Doc PR        | /

In 4.0, enhanced sigchild compatibility is always enabled.

Commits
-------

1aa7d68 Remove enhance sigchild compatibility
@fabpot fabpot mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants