[DependencyInjection] non-conflicting anonymous service ids across files #23490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 12, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23483 |
| License | MIT |
| Doc PR |
ro0NL
reviewed
Jul 12, 2017
| @@ -546,7 +546,7 @@ public function testAnonymousServices() | |||
| $this->assertInternalType('array', $factory); | |||
| $this->assertInstanceOf(Reference::class, $factory[0]); | |||
| $this->assertTrue($container->has((string) $factory[0])); | |||
| $this->assertStringStartsWith('1', (string) $factory[0]); | |||
| $this->assertRegExp('/^\d+_[A-Z0-9]{64}$/i', (string) $factory[0]); | |||
There was a problem hiding this comment.
Coul add a-z range to avoid i modifier
ab2034a to
80d2085
Compare
|
No, the |
fabpot
approved these changes
Jul 12, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 12, 2017
…s across files (xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [DependencyInjection] non-conflicting anonymous service ids across files | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23483 | License | MIT | Doc PR | Commits ------- 8289ca6 non-conflicting anonymous service ids across files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.