Remove last legacy codes #23569
Merged
Remove last legacy codes #23569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 18, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
Needs #23570 before merge |
nicolas-grekas
commented
Jul 18, 2017
| @@ -54,7 +54,6 @@ public function __construct(HttpKernelInterface $kernel, $cacheDir = null) | |||
| protected function forward(Request $request, $raw = false, Response $entry = null) | |||
| { | |||
| $this->getKernel()->boot(); | |||
| $this->getKernel()->getContainer()->set('cache', $this); // to be removed in 4.0? | |||
There was a problem hiding this comment.
ping @ro0NL any comment here?
There was a problem hiding this comment.
perhaps move to a deprecated definition? it aliases @kernel basically. Otherwise keep it / uncomment :)
There was a problem hiding this comment.
let's keep it, it doesn't hurt
There was a problem hiding this comment.
comment removed in 0bd1f09
fabpot
added a commit
that referenced
this pull request
Jul 18, 2017
…viceSubscriberInterface (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Blocks #23569 Commits ------- c0af003 [FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface
|
rebased and ready |
xabbuh
approved these changes
Jul 18, 2017
ogizanagi
approved these changes
Jul 18, 2017
fabpot
approved these changes
Jul 19, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- Remove last legacy codes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 86ec5e1 Remove last legacy codes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.