[Yaml] mark some classes as final #24028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Aug 29, 2017
f9db245 to
330c6bf
Compare
javiereguiluz
approved these changes
Aug 30, 2017
ogizanagi
approved these changes
Aug 30, 2017
xabbuh
added a commit
that referenced
this pull request
Aug 30, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] mark some classes as final | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Making these classes final unlocks more scalar type hint possibilities on top of the changes proposed in #23262. Commits ------- 330c6bf [Yaml] mark some classes as final
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making these classes final unlocks more scalar type hint possibilities on top of the changes proposed in #23262.