Deprecated the web_profiler.position option #24080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Sep 4, 2017
| ->beforeNormalization() | ||
| ->ifTrue(function ($v) { return null !== $v; }) | ||
| ->then(function () { | ||
| @trigger_error('The "web_profiler.position" configuration key has been deprecated in Symfony 3.4 and it will be removed in 4.0.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
We can now use setDeprecated() instead, right?
There was a problem hiding this comment.
@javiereguiluz Can you make the change?
fabpot
approved these changes
Sep 7, 2017
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2017
…iluz) This PR was squashed before being merged into the 3.4 branch (closes #24080). Discussion ---------- Deprecated the web_profiler.position option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #23528 | License | MIT | Doc PR | - Related to #23728, which removes the feature for Symfony 4.0. Commits ------- 53387b4 Deprecated the web_profiler.position option
This was referenced Oct 18, 2017
Merged
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…viereguiluz) This PR was squashed before being merged into the 3.4 branch (closes symfony#24080). Discussion ---------- Deprecated the web_profiler.position option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#23528 | License | MIT | Doc PR | - Related to symfony#23728, which removes the feature for Symfony 4.0. Commits ------- 53387b4 Deprecated the web_profiler.position option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23728, which removes the feature for Symfony 4.0.