[Bridge\Doctrine] Add "DoctrineType::reset()" method #24232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2017
ogizanagi
approved these changes
Sep 17, 2017
derrabus
reviewed
Sep 18, 2017
|
|
||
| public function reset() | ||
| { | ||
| $this->choiceLoaders = array(); |
There was a problem hiding this comment.
You're throwing away all choice loaders. Wouldn't it be enough to iterate over all choice loaders and reset the $choiceList property of each of them?
There was a problem hiding this comment.
Looking at the code, I think it's fine this way: clearing DoctrineChoiceLoader::$choiceList would require more CPU here, but wouldn't save much on new iterations.
derrabus
approved these changes
Sep 18, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2017
…nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Bridge\Doctrine] Add "DoctrineType::reset()" method | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23984 | License | MIT | Doc PR | - Works with doctrine/DoctrineBundle#695 Commits ------- dce1eb9 [Bridge\Doctrine] Add "DoctrineType::reset()" method
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with doctrine/DoctrineBundle#695