[SecurityBundle] Add missing AclSchemaListener deprecation #24349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Sep 27, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2017
…tion (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Add missing AclSchemaListener deprecation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Missing from #24318 Commits ------- d43c1f7 [SecurityBundle] Add missing AclSchemaListener deprecation
Tobion
reviewed
Sep 29, 2017
| @@ -11,13 +11,17 @@ | |||
|
|
|||
| namespace Symfony\Bundle\SecurityBundle\EventListener; | |||
|
|
|||
| @trigger_error(sprintf('Class "%s" is deprecated since version 3.4 and will be removed in 4.0. Use Symfony\Bundle\AclBundle\EventListener\SetAclCommand instead.', AclSchemaListener::class), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
looks like a copy paste error on the alternative class
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing from #24318