[FrameworkBundle] Register a NullLogger from test kernels #24385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation sounds good for now. In any case, #24300 will need some tweaks. I've tested in real-life, and this does not work well IMHO. |
fabpot
approved these changes
Sep 30, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2017
…s (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Register a NullLogger from test kernels | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Relates to #24300 This will avoid unnecessary output on Travis or when running FrameworkBundle tests locally: - before: https://travis-ci.org/symfony/symfony/jobs/281624658#L3594-L3635 - after: https://travis-ci.org/symfony/symfony/jobs/281643868#L3599-L3617 but also needed for anyone running functional tests on their project and using the default logger, in order to not get garbage output. Do we need to find a more generic solution (like exposing a `framework.default_logger` option so users can set it to false for test)? Or just documenting this? Commits ------- c109dcd [FrameworkBundle] Register a NullLogger from test kernels
3 tasks
ogizanagi
added a commit
to Elao/PhpEnums
that referenced
this pull request
Nov 8, 2017
This PR was merged into the 1.x-dev branch. Discussion ---------- Update symfony 4 compatibility TODO: - [x] Update tests to use new PHPUnit namespaces - [x] Fix phpunit version used through env var - [x] Inject a `NullLogger` (see symfony/symfony#24385) Commits ------- 64fc69d Use new PhpUnit namespaces a4705a5 Inject a NullLogger for integration tests 46e775c Moar travis changes e438be5 Update symfony 4 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #24300
This will avoid unnecessary output on Travis or when running FrameworkBundle tests locally:
but also needed for anyone running functional tests on their project and using the default logger, in order to not get garbage output.
Do we need to find a more generic solution (like exposing a
framework.default_loggeroption so users can set it to false for test)? Or just documenting this?