[DoctrineBridge] Deprecate dbal session handler #24389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 1, 2017
|
Just wondering: should we make PdoSessionHandler accept DBAL connections? |
javiereguiluz
approved these changes
Oct 2, 2017
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [DoctrineBridge] Deprecate dbal session handler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #20501 | License | MIT | Doc PR | The DbalSessionHandler misses all the improvements from the PdoSessionHandler (lock modes, delayed GC, configurable naming). The only advantage it had was the ability to work with non-pdo drivers. But since DBAL requires PDO now as well (doctrine/dbal@36df682) even that is not really relevant anymore. Stofs argument in #20501 (comment) sound like a new feature that can be implemented separately. Ref. #24267 Commits ------- ffc74eb [DoctrineBridge] Deprecate DbalSessionHandler
|
PR welcomed on master to remove the legacy code. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Session] remove deprecated session handlers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8486 Removes deprecated session handler from #24389, #24438 and #24443 Commits ------- 0a7af3f [Session] remove deprecated session handlers
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Add changelog for deprecated DbalSessionHandler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Add missing changelog/upgrade for #24389 Commits ------- af0aa1e Add changelog for deprecated DbalSessionHandler
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DbalSessionHandler misses all the improvements from the PdoSessionHandler (lock modes, delayed GC, configurable naming). The only advantage it had was the ability to work with non-pdo drivers. But since DBAL requires PDO now as well (doctrine/dbal@36df682) even that is not really relevant anymore.
Stofs argument in #20501 (comment) sound like a new feature that can be implemented separately. Ref. #24267