[Form] Use for=ID on radio/checkbox label. #24434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstok
reviewed
Oct 5, 2017
| @@ -147,10 +147,14 @@ | |||
| {% endblock choice_label %} | |||
|
|
|||
| {% block checkbox_label -%} | |||
| {%- set label_attr = label_attr|merge({for: id}) -%} | |||
There was a problem hiding this comment.
really? I never quote the keys in Twig (unless strictly required because of white spaces, etc.)
There was a problem hiding this comment.
Quoting is no requirement in Twig. I thought Sebastian suggested it because it is a part of the code standard.
sstok
suggested changes
Oct 5, 2017
|
Thank you for the review. Yeah you might be correct. This could be considered a bugfix. |
|
To me that's a bugfix. |
|
@Nyholm Can you change the base branch to 2.7 (I think that should be considered as a bug fix). |
Simperfit
approved these changes
Oct 5, 2017
|
Tried to do it on the phone and failed. Will fix this when I get to a computer. Thank you for the reviews. |
This is required for some screen reader like Jaws
|
Added the fix for branch 2.7 |
|
I wonder if we don't have to update any test fixtures. |
nicolas-grekas
approved these changes
Oct 8, 2017
|
Thank you @Nyholm. |
fabpot
approved these changes
Oct 8, 2017
fabpot
added a commit
that referenced
this pull request
Oct 8, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Use for=ID on radio/checkbox label. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I recently let Europe's leading accessibility experts (Funkanu.se) review a site of mine, they gave me (among other) this feedback. > Putting the checkbox/radio input inside the label is great, but the label still needs the "for=ID". Screen readers like Jaws does not work properly without this attribute. Commits ------- 53d7857 Use for=ID on radio/checkbox label.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently let Europe's leading accessibility experts (Funkanu.se) review a site of mine, they gave me (among other) this feedback.