Username and password in basic auth are allowed to contain '.' #24589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially reported by Fede Isas in beberlei/assert#234
|
Ahh. 2.3 is the first version to validate the basic auth part of a url. But that is failing due to the PHP5.3. Should I have made a PR against 2.7? |
|
Yes, 2.7 is the lowest branch that is still maintained. 2.3 isn't maintained anymore. |
fabpot
approved these changes
Oct 18, 2017
|
Thank you @rquadling. |
fabpot
added a commit
that referenced
this pull request
Oct 18, 2017
… '.' (Richard Quadling) This PR was merged into the 2.7 branch. Discussion ---------- Username and password in basic auth are allowed to contain '.' Initially reported by Fede Isas in beberlei/assert#234 | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- e5d57dd Username and password in basic auth are allowed to contain '.'
|
Thank's to @fedeisas. |
This was referenced Oct 30, 2017
Merged
Merged
This was referenced Nov 10, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially reported by Fede Isas in beberlei/assert#234