From 0fc2282fc2242f0ecb4b13437383d9f62cb5bd6b Mon Sep 17 00:00:00 2001 From: Yonel Ceruto Date: Thu, 19 Oct 2017 12:41:04 -0400 Subject: [PATCH 1/3] fix the constant value to be consistent with the name --- src/Symfony/Component/Form/FormEvents.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/Form/FormEvents.php b/src/Symfony/Component/Form/FormEvents.php index b795f95dcfafc..c9b01736d495f 100644 --- a/src/Symfony/Component/Form/FormEvents.php +++ b/src/Symfony/Component/Form/FormEvents.php @@ -31,7 +31,7 @@ final class FormEvents * * @Event("Symfony\Component\Form\FormEvent") */ - const PRE_SUBMIT = 'form.pre_bind'; + const PRE_SUBMIT = 'form.pre_submit'; /** * The SUBMIT event is dispatched just before the Form::submit() method @@ -41,7 +41,7 @@ final class FormEvents * * @Event("Symfony\Component\Form\FormEvent") */ - const SUBMIT = 'form.bind'; + const SUBMIT = 'form.submit'; /** * The FormEvents::POST_SUBMIT event is dispatched after the Form::submit() @@ -51,7 +51,7 @@ final class FormEvents * * @Event("Symfony\Component\Form\FormEvent") */ - const POST_SUBMIT = 'form.post_bind'; + const POST_SUBMIT = 'form.post_submit'; /** * The FormEvents::PRE_SET_DATA event is dispatched at the beginning of the Form::setData() method. From 0ee856add1f641e1f21aac30a69dceaa464bd9c4 Mon Sep 17 00:00:00 2001 From: Yonel Ceruto Date: Thu, 19 Oct 2017 13:35:16 -0400 Subject: [PATCH 2/3] Update UPGRADE-4.0.md --- UPGRADE-4.0.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md index 000fd2fc059d8..307d12f1a4b67 100644 --- a/UPGRADE-4.0.md +++ b/UPGRADE-4.0.md @@ -226,6 +226,9 @@ Finder Form ---- + * The constant values of `FormEvents::*` have been renamed to match with its name. + May break rare cases where the event name is used rather than the constant. + * The `choices_as_values` option of the `ChoiceType` has been removed. * Support for data objects that implements both `Traversable` and From 944931af633ba6fe0d5a27763a563a0d798f0252 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Thu, 19 Oct 2017 20:08:49 +0200 Subject: [PATCH 3/3] Minor reword --- UPGRADE-4.0.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md index 307d12f1a4b67..c2f3753d2a7b6 100644 --- a/UPGRADE-4.0.md +++ b/UPGRADE-4.0.md @@ -226,8 +226,9 @@ Finder Form ---- - * The constant values of `FormEvents::*` have been renamed to match with its name. - May break rare cases where the event name is used rather than the constant. +* The values of the `FormEvents::*` constants have been updated to match the + constant names. You should only update your application if you relied on the + constant values instead of their names. * The `choices_as_values` option of the `ChoiceType` has been removed.