[Security] remove invalid deprecation notice on AbstractGuardAuthenticator::supports() #24684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
The supports() method is the first called in the lifecycle of an authenticator, if it returns false then the authenticator is skipped. It's unlikely to be called except by the guard handler.
For the record, this true-returning method allows to warn subclasses when they don't implement the new method while making the abstract implements the new interface.
We don't want the DebugClassLoader to trigger if users redefine it since this is what we ask them to do for upgrading.
|
It will also prevent me from thinking I am doing something wrong in my IDE :)
|
ogizanagi
approved these changes
Oct 25, 2017
fabpot
approved these changes
Oct 25, 2017
|
Thank you @kbond. |
fabpot
added a commit
that referenced
this pull request
Oct 25, 2017
…ardAuthenticator::supports() (kbond) This PR was merged into the 3.4 branch. Discussion ---------- [Security] remove invalid deprecation notice on AbstractGuardAuthenticator::supports() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16835 (comment) | License | MIT | Doc PR | n/a This deprecation flag causes a false positive. Commits ------- 5fb44e7 [Guard] remove invalid deprecation notice
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecation flag causes a false positive.