Ensure DeprecationErrorHandler::collectDeprecations() is triggered #24696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SYMFONY_DEPRECATIONS_SERIALIZE is set
|
We tried this before in #24685 but got it wrong. |
|
I've run src/Symfony/Component/Process/Tests/ProcessTest.php locally and this version does not seem to cause the same problems |
| @@ -262,6 +262,7 @@ public function endTest($test, $time) | |||
| if ($this->runsInSeparateProcess) { | |||
| $deprecations = file_get_contents($this->runsInSeparateProcess); | |||
| unlink($this->runsInSeparateProcess); | |||
| putenv('SYMFONY_DEPRECATIONS_SERIALIZE='); | |||
There was a problem hiding this comment.
the = should be removed, to really remove the env var (the = makes it the empty string, where we want to delete it, isn't it?)
nicolas-grekas
approved these changes
Oct 26, 2017
|
Thank you @alexpott. |
This was referenced Oct 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure DeprecationErrorHandler::collectDeprecations() is triggered if SYMFONY_DEPRECATIONS_SERIALIZE is set
Drupal doesn't use src/Symfony/Bridge/PhpUnit/bin/simple-phpunit but would like to use the deprecation collection features of src/Symfony/Bridge/PhpUnit. The checks in src/Symfony/Bridge/PhpUnit/bootstrap.php mean that this is difficult because they rely on simple-phpunit - but I'm not sure that that is necessary.
The problem is even in isolated tests we have PHPUNIT_COMPOSER_INSTALL set because we use a custom phpunit config file.