Skip to content

[Validator] ExpressionValidator should use OBJECT_TO_STRING #24750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

[Validator] ExpressionValidator should use OBJECT_TO_STRING #24750

merged 1 commit into from
Dec 1, 2017

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Oct 30, 2017 •
edited
Loading

…value in message

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24595
License MIT
Doc PR Will do.

@Simperfit Simperfit force-pushed the feautre/expression-validator-string-for-value-message branch from efd8265 to ec92196 Compare October 30, 2017 05:26
@nicolas-grekas
Copy link
Member

For which branch is this PR?

@Simperfit
Copy link
Contributor Author

Simperfit commented Oct 30, 2017 via email

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Oct 30, 2017
@Simperfit Simperfit force-pushed the feautre/expression-validator-string-for-value-message branch 4 times, most recently from f07dbc6 to 8b0e61f Compare November 1, 2017 13:58
@fabpot
Copy link
Member

fabpot commented Dec 1, 2017

It looks like a bug to me. The current behavior does not make much sense, it "works" by change. Displaying a generic "object" string is never something one would expect, right?

@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2017

fine for me as a bugfix too

ogizanagi
ogizanagi approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed too 👍

@Simperfit Simperfit force-pushed the feautre/expression-validator-string-for-value-message branch from 8b0e61f to 7dac528 Compare December 1, 2017 17:16
@Simperfit Simperfit changed the base branch from master to 2.7 December 1, 2017 17:16
@Simperfit
Copy link
Contributor Author

rebased to 2.7

@fabpot
Copy link
Member

fabpot commented Dec 1, 2017

Thank you @Simperfit.

@fabpot fabpot merged commit 7dac528 into symfony:2.7 Dec 1, 2017
fabpot added a commit that referenced this pull request Dec 1, 2017
@fabpot
bug #24750 [Validator] ExpressionValidator should use OBJECT_TO_STRIN…
5a6e2d7 
…G (Simperfit)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] ExpressionValidator should use OBJECT_TO_STRING

…value in message

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24595
| License       | MIT
| Doc PR        | Will do.

Commits
-------

7dac528 [Validator] ExpressionValidator should use OBJECT_TO_STRING to allow value in message
This was referenced Dec 4, 2017
Merged
Merged
Merged
This was referenced Dec 4, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug Feature Status: Reviewed Validator
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
7 participants
@Simperfit @nicolas-grekas @fabpot @xabbuh @dunglas @ogizanagi @carsonbot