[Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone #25056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2017
…vendor/ and in phpunit clone (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Right now, the bridge is installed at least twice: in vendor/ of the tested package, and in phpunit's clone. By forcing the vendor one to be used for the phpunit clone also, we sync the version of the code, so that things become more manageable and easier to debug. Applies also to our own CI. Commits ------- 038c671 [Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Bump phpunit-bridge requirement to 3.4|4.0 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The bridge 4.0 is already used because of the way simple-phpunit works. This just make it more explicit and will be required when #25056 will be merged. Commits ------- 1c1a540 Bump phpunit-bridge requirement to 3.4|4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the bridge is installed at least twice: in vendor/ of the tested package, and in phpunit's clone.
By forcing the vendor one to be used for the phpunit clone also, we sync the version of the code, so that things become more manageable and easier to debug.
Applies also to our own CI.