[Routing] Fix "config-file-relative" annotation loader resources #25113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See symfony/recipes#272 for a corresponding recipe (verified locally.) |
|
Note that it would be great to deprecate using the |
2ca0359 to
289a000
Compare
dunglas
approved these changes
Nov 23, 2017
|
Can you add some tests for that? |
|
This one makes is difficult (read impossible) to have a config that works on 3.3 and 3.4/4.0 (cf. the changed recipe). |
|
The current config that works will continue to work. I'm now rebasing on 3.3 as bug fix, so that Flex+3.3 can get the good DX config. |
289a000 to
5998e9d
Compare
|
rebased on 3.3 |
fabpot
approved these changes
Nov 23, 2017
|
And we even have tests now 👍 |
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 24, 2017
…ources (nicolas-grekas, sroze) This PR was merged into the 3.3 branch. Discussion ---------- [Routing] Fix "config-file-relative" annotation loader resources | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | slight behavior change | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - By using the locator in its `supports()` method, the `AnnotationDirectoryLoader` breaks config-relative annotation resources. The workaround is to fallback on `kernel.root_dir`-relative paths, as done in https://github.com/symfony/recipes/blob/master/doctrine/annotations/1.0/config/routes/annotations.yaml But as you can see, this is rather WTF: extra knowledge is required to know what to type there. All the other loader look relatively to the config file first. This is a bug, but since this is a slight behavior change, I think it's best to merge it on 3.4. Commits ------- f4999d8 Add tests proving it can load annotated files 5998e9d [Routing] Fix "config-file-relative" annotation loader resources
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the locator in its
supports()method, theAnnotationDirectoryLoaderbreaks config-relative annotation resources. The workaround is to fallback onkernel.root_dir-relative paths, as done in https://github.com/symfony/recipes/blob/master/doctrine/annotations/1.0/config/routes/annotations.yamlBut as you can see, this is rather WTF: extra knowledge is required to know what to type there. All the other loader look relatively to the config file first.
This is a bug, but since this is a slight behavior change, I think it's best to merge it on 3.4.