[WebProfilerBundle] [TwigBundle] Fix Profiler breaking XHTML pages #25232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Content-Type: application/xhtml+xml)
|
Would be OK as bug fix on 3.3 also. |
stof
approved these changes
Dec 1, 2017
|
@tistre thanks for fixing this issue. Could you please rebase it to 3.3 to merge it as a bug fix instead of a new feature? Thanks! |
|
Thank you @tistre. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2017
…ML pages (tistre) This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #25232). Discussion ---------- [WebProfilerBundle] [TwigBundle] Fix Profiler breaking XHTML pages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Just a tiny fix: Stop the Profiler from breaking XHTML pages (served with "Content-Type: application/xhtml+xml") - with the added quotes around the nonce attribute value, the page remains well-formed XML. Commits ------- b1ab7d0 [WebProfilerBundle], [TwigBundle] Fix Profiler breaking XHTML pages (Content-Type: application/xhtml+xml)
|
I fact it applied cleanly on 3.3, so it's merged now. |
This was referenced Dec 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny fix: Stop the Profiler from breaking XHTML pages (served with "Content-Type: application/xhtml+xml") - with the added quotes around the nonce attribute value, the page remains well-formed XML.