From a8df0aee926270a6d51851e81299c044ce5b5dde Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 23 Feb 2018 09:21:43 +0100 Subject: [PATCH] clarify changelog and upgrade instructions --- UPGRADE-4.1.md | 3 ++- UPGRADE-5.0.md | 4 ++-- src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/UPGRADE-4.1.md b/UPGRADE-4.1.md index 520bf9b7eb888..3dbf4f232af67 100644 --- a/UPGRADE-4.1.md +++ b/UPGRADE-4.1.md @@ -47,7 +47,8 @@ FrameworkBundle ``` * Deprecated `Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser` - * A `RouterInterface` that does not implement the `WarmableInterface` is deprecated. + * Warming up a router in `RouterCacheWarmer` that does not implement the `WarmableInterface` is deprecated and will not be + supported anymore in 5.0. * The `RequestDataCollector` class has been deprecated. Use the `Symfony\Component\HttpKernel\DataCollector\RequestDataCollector` class instead. HttpFoundation diff --git a/UPGRADE-5.0.md b/UPGRADE-5.0.md index 472d53a4b3a59..ec3342682b3ed 100644 --- a/UPGRADE-5.0.md +++ b/UPGRADE-5.0.md @@ -45,8 +45,8 @@ FrameworkBundle _controller: app.my_controller::myAction ``` - * Removed `Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser` - * Using a `RouterInterface` that does not implement the `WarmableInterface` is not supported anymore. + * Removed `Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser`. + * Warming up a router in `RouterCacheWarmer` that does not implement the `WarmableInterface` is not supported anymore. * The `RequestDataCollector` class has been removed. Use the `Symfony\Component\HttpKernel\DataCollector\RequestDataCollector` class instead. HttpFoundation diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md index d9ac54c562469..94bf1ca055d0e 100644 --- a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md +++ b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md @@ -9,6 +9,8 @@ CHANGELOG * Allowed the `Router` to work with any PSR-11 container * Added option in workflow dump command to label graph with a custom label * Using a `RouterInterface` that does not implement the `WarmableInterface` is deprecated. + * Warming up a router in `RouterCacheWarmer` that does not implement the `WarmableInterface` is deprecated and will not + be supported anymore in 5.0. * The `RequestDataCollector` class has been deprecated. Use the `Symfony\Component\HttpKernel\DataCollector\RequestDataCollector` class instead. * The `RedirectController` class allows for 307/308 HTTP status codes * Deprecated `bundle:controller:action` syntax to reference controllers. Use `serviceOrFqcn::method` instead where `serviceOrFqcn`