Skip to content

Mark ExceptionInterfaces throwable #26702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Mark ExceptionInterfaces throwable #26702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Asset/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Fabien Potencier <fabien@symfony.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Jérôme Tamarelle <jerome@tamarelle.net>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/CssSelector/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
*
* @author Jean-François Simon <jeanfrancois.simon@sensiolabs.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Dotenv/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Fabien Potencier <fabien@symfony.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Filesystem/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Romain Neutron <imprec@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Form/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Intl/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Ldap/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Charles Sarrazin <charles@sarraz.in>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Lock/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Jérémy Derussé <jeremy@derusse.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Messenger/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Samuel Roze <samuel.roze@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/OptionsResolver/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This interface, like the equivalent ones throughout the other components (about 20 of them), is meant to be a marker, nothing more.

So, I would not extend \Throwable here. But if we decide to do so, would it make sense to do it on all our markers?

Copy link
Contributor Author

@ostrolucky ostrolucky Mar 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This marker is for exceptions though, shouldn't it guarantee it's used on exception classes only?

How about deprecating this interface and replacing it another interface, extending Throwable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating implies to find a name for the replacement in addition to bother our users, I don't think it's worth the hassle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding name, it could be {Component}ExceptionInterface. E.g. ConsoleExceptionInterface.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to extend Throwable everywhere to semantically indicate that it is for exceptions. No need for deprecations as this should not break anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok at least somebody is with me, so I've applied this change in rest of the components as well.

{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Process/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Johannes M. Schmitt <schmittjoh@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/PropertyAccess/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Routing/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Alexandre Salomé <alexandre.salome@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Core/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Serializer/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Johannes M. Schmitt <schmittjoh@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Translation/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Fabien Potencier <fabien@symfony.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Validator/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Bernhard Schussek <bschussek@gmail.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Workflow/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
* @author Fabien Potencier <fabien@symfony.com>
* @author Grégoire Pineau <lyrixx@lyrixx.info>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/Yaml/Exception/ExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
*
* @author Fabien Potencier <fabien@symfony.com>
*/
interface ExceptionInterface
interface ExceptionInterface extends \Throwable
{
}