Bugfix/simple authentication provider anonymous token #26808
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an $authToken is anonymous (i.e. getUser() returns 'anon.') a fatal error is thrown due to the user checker expecting arguments to checkPreAuth() and checkPostAuth() to be of the type UserInterface. This commit type-checks the user before passing is to the user checker.
|
Looks like #26788 has addressed this specific issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkPreAuth()andcheckPostAuth()methods on theUserCheckerInterfaceexpect their argument to be an instance ofUserInterface. When theSimpleAuthenticationProvideracquires a token, it doesn't confirm this fact before checking the user. For instance, when theSimpleAuthenticationProvider'sSimpleAuthenticatorInterfaceinstance returns an anonymous token (i.e. a token whosegetUser()interface returns"anon.") a fatal error is thrown due to the type mismatch when calling the user checker check* methods.This branch confirms the user is an instance of UserInterface before passing it to the checker.