Make the simple auth provider the same as in Symfony 2.7 #27059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @leofeyer. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2018
… (leofeyer) This PR was merged into the 2.8 branch. Discussion ---------- Make the simple auth provider the same as in Symfony 2.7 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27044 | License | MIT This PR adds the `SimpleAuthenticationProvider` changes made in Symfony 2.7 to Symfony 2.8. See #27044 (comment) Commits ------- 9afad9d Make the simple auth provider the same as in Symfony 2.7.
chalasr
reviewed
Apr 26, 2018
| @@ -50,20 +48,7 @@ public function authenticate(TokenInterface $token) | |||
| $user = $authToken->getUser(); | |||
|
|
|||
| if (!$user instanceof UserInterface) { | |||
| try { | |||
| $user = $this->userProvider->loadUserByUsername($user); | |||
There was a problem hiding this comment.
this is the currently not covered case which does not exist on 2.7. loadUserByUsername() should throw when no user can be found for the passed username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
SimpleAuthenticationProviderchanges made in Symfony 2.7 to Symfony 2.8. See #27044 (comment)