[WebProfilerBundle] Make Twig bundle an explicit dependency #27417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't it be the WebProfilerBundle composer instead TwigBundle? It's referencing itself |
ogizanagi
previously requested changes
May 30, 2018
| "symfony/http-kernel": "~3.4|~4.0", | ||
| "symfony/polyfill-ctype": "~1.8", | ||
| "twig/twig": "~1.34|~2.4" | ||
| "symfony/twig-bundle": "^3.4.3|^4.0.3", |
There was a problem hiding this comment.
You're looking for troubles by requiring it itself 😅
Should actually be in Symfony/Bundle/WebProfilerBundle/composer.json, not TwigBundle's composer.json.
nicolas-grekas
approved these changes
May 30, 2018
stof
approved these changes
May 30, 2018
ogizanagi
approved these changes
May 30, 2018
fabpot
added a commit
that referenced
this pull request
May 30, 2018
…dency (fabpot) This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Make Twig bundle an explicit dependency | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26115 | License | MIT Let's make Twig bundle an explicit dependency of WebProfilerBundle. That's better for DX and as Silex won't be maintained when 4.2 is out, it's the right time to do so. Commits ------- cac37ca [WebProfilerBundle] made Twig bundle an explicit dependency
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make Twig bundle an explicit dependency of WebProfilerBundle. That's better for DX and as Silex won't be maintained when 4.2 is out, it's the right time to do so.