[Form] relax fixtures for forward compat #27771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b85e06c to
a17df3b
Compare
a17df3b to
2258ce4
Compare
chalasr
approved these changes
Jun 29, 2018
|
Thank you @nicolas-grekas. |
chalasr
pushed a commit
that referenced
this pull request
Jun 29, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Form] relax fixtures for forward compat | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Required to make #27768 green. Commits ------- 2258ce4 [Form] relax fixtures for forward compat
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Fix fixtures for forward compat | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/398533738#L4394-L4407 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Completes #27771 in order to fix https://travis-ci.org/symfony/symfony/jobs/398533738#L4394-L4407. As the Closure signature is variable, we cannot assume the exact number of whitespaces after it, nor if it will or not overtake the length of the `file:` line. So let's just assume an undetermined nb of whitespaces. Commits ------- 582d797 [Form] Fix fixtures for forward compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to make #27768 green.