Skip to content

[Dotenv] use array instead of variadic in Dotenv::doLoad() #28359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

[Dotenv] use array instead of variadic in Dotenv::doLoad() #28359

merged 1 commit into from
Sep 5, 2018

Conversation

fmata
Copy link
Contributor

@fmata fmata commented Sep 4, 2018

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT

According to comments done after merge in #26859.

@fmata fmata mentioned this pull request Sep 4, 2018
Merged
@stof
Copy link
Member

stof commented Sep 4, 2018

I'm wondering whether we should move the unshift into both public methods. That would avoid creating a copy of the array, but the copy might not be a big issue (it is unlikely to pass a huge array there)

@xabbuh
Copy link
Member

xabbuh commented Sep 5, 2018

Moving array_unshift() into the calling methods would at least improve the readability of doLoad() IMO. But that's not a blocker to me.

@fabpot
Copy link
Member

fabpot commented Sep 5, 2018

Thank you @fmata.

@fabpot fabpot merged commit f3af242 into symfony:master Sep 5, 2018
fabpot added a commit that referenced this pull request Sep 5, 2018
@fabpot
minor #28359 [Dotenv] use array instead of variadic in Dotenv::doLoad…
14fa58e 
…() (fmata)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Dotenv] use array instead of variadic in Dotenv::doLoad()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT

According to comments done after merge in #26859.

Commits
-------

f3af242 [Dotenv] use array instead of variadic in Dotenv::doLoad()
@fmata fmata deleted the issue-26846-followup branch September 5, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fmata @stof @xabbuh @fabpot @chalasr @carsonbot