Skip to content

[VarDumper] add caster for Memcached #28622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2018
Merged

[VarDumper] add caster for Memcached #28622

merged 1 commit into from
Nov 2, 2018

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Sep 27, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28597
License MIT
Doc PR -

@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch 2 times, most recently from 8a8e7b6 to a025c9d Compare September 27, 2018 15:58
@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch from ae08d2d to cb55522 Compare September 27, 2018 16:49
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 29, 2018
@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch from 1fabe96 to 1dd8288 Compare September 29, 2018 18:08
@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch 2 times, most recently from 2ee39b8 to 41c3bd6 Compare September 30, 2018 11:03
@jschaedl
Copy link
Contributor Author

jschaedl commented Oct 1, 2018

@stof Do you have any other change requests?

@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch from e92dd16 to f0a6120 Compare October 2, 2018 09:17
@fabpot
Copy link
Member

fabpot commented Oct 16, 2018

@jschaedl Do you have time to finish this PR?

@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch from e118fa6 to 95e83a9 Compare October 23, 2018 08:38
@jschaedl
Copy link
Contributor Author

jschaedl commented Nov 2, 2018

@fabpot @nicolas-grekas

Please let me know if there are more changes needed.

@jschaedl jschaedl force-pushed the vd-add_caster_for_memcached branch 2 times, most recently from 3eeb3bb to 5f2702b Compare November 2, 2018 10:50
@nicolas-grekas nicolas-grekas force-pushed the vd-add_caster_for_memcached branch from 5f2702b to f95d943 Compare November 2, 2018 11:05
@nicolas-grekas
Copy link
Member

Thank you @jschaedl.

@nicolas-grekas nicolas-grekas merged commit f95d943 into symfony:master Nov 2, 2018
nicolas-grekas added a commit that referenced this pull request Nov 2, 2018
@nicolas-grekas
feature #28622 [VarDumper] add caster for Memcached (jschaedl)
79bbee2 
This PR was squashed before being merged into the 4.2-dev branch (closes #28622).

Discussion
----------

[VarDumper] add caster for Memcached

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28597
| License       | MIT
| Doc PR        | -

Commits
-------

f95d943 [VarDumper] add caster for Memcached
This was referenced Nov 3, 2018
Closed
Merged
@stof stof modified the milestones: next, 4.2 Nov 23, 2018
@jschaedl jschaedl deleted the vd-add_caster_for_memcached branch February 23, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof requested changes

Assignees
No one assigned
Labels
Feature Status: Reviewed VarDumper
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@jschaedl @fabpot @nicolas-grekas @stof @carsonbot