[Console] Don't return early as this bypasses the auto exit feature #28664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 1, 2018
|
Testing this case would indeed be harder. A way could be to run a subprocess running the Application class and checking the exit code of the command (if the call to |
chalasr
approved these changes
Oct 1, 2018
|
Thank you @duncan3dc. |
chalasr
pushed a commit
that referenced
this pull request
Oct 1, 2018
…t feature (duncan3dc) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Don't return early as this bypasses the auto exit feature | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT It looks like 8805cfd broke the auto exit feature by returning early. I couldn't find any tests for this feature (presumably because it uses `exit()`), I was going to write one using uopz but didn't want to do this work if Symfony intentionally doesn't test the call to `exit()` Commits ------- b6c17df Don't return early as this bypasses the auto exit feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like 8805cfd broke the auto exit feature by returning early.
I couldn't find any tests for this feature (presumably because it uses
exit()), I was going to write one using uopz but didn't want to do this work if Symfony intentionally doesn't test the call toexit()