[LDAP] Revamp LDAP options with nested options definition #28839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73c3f38 to
a26c284
Compare
fabpot
approved these changes
Oct 12, 2018
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2018
…n (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [LDAP] Revamp LDAP options with nested options definition | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Next move after #27291 :) This will work exactly that before, nothing change regarding behavior, BUT now we've *less code* and *intuitive definition of nested options*. Commits ------- a26c284 Revamp LDAP options with nested definition
ostrolucky
reviewed
Oct 12, 2018
| "ext-ldap": "*" | ||
| }, | ||
| "conflict": { | ||
| "symfony/options-resolver": "<4.2" |
There was a problem hiding this comment.
adding this is useless, constraint in require section already guarantees it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next move after #27291 :)
This will work exactly that before, nothing change regarding behavior, BUT now we've less code and intuitive definition of nested options.