also clean away the NO_AUTO_CACHE_CONTROL_HEADER if we have no session #28960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Would it possible to cover this by a test case? |
|
good point with the tests. did need to move getting the request up... i think its ok to expand on the existing test and make it do a bit more, rather than create a separate test. okay like this? |
dmaicher
approved these changes
Oct 23, 2018
fabpot
approved these changes
Oct 24, 2018
|
Thank you @dbu. |
fabpot
added a commit
that referenced
this pull request
Oct 24, 2018
…e no session (dbu) This PR was merged into the 4.1 branch. Discussion ---------- also clean away the NO_AUTO_CACHE_CONTROL_HEADER if we have no session | Q | A | ------------- | --- | Branch? | 4.1 (feature added in this branch) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This header is not supposed to ever be exposed to clients of the application, but a hack to transfer information within the symfony application. This bugfix makes it so that we also remove the header when no session is started and thus no decision has to be taken whether to overwrite the caching instructions or not. Commits ------- 28d9f0c also clean away the NO_AUTO_CACHE_CONTROL_HEADER if we have no session
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header is not supposed to ever be exposed to clients of the application, but a hack to transfer information within the symfony application. This bugfix makes it so that we also remove the header when no session is started and thus no decision has to be taken whether to overwrite the caching instructions or not.