-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[VarDumper] fix dump of closures created from callables #29054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eff20df
to
1034a66
Compare
yceruto
reviewed
Nov 1, 2018
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Nov 1, 2018
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/MarkdownDescriptor.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Nov 1, 2018
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/XmlDescriptor.php
Outdated
Show resolved
Hide resolved
1034a66
to
892b6a1
Compare
ro0NL
reviewed
Nov 2, 2018
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php
Show resolved
Hide resolved
892b6a1
to
1c1818b
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2018
…icolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] fix dump of closures created from callables | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - We are missing displaying full information about closures created using `ReflectionMethod::getClosure()` or `Closure::fromCallable()`. This PR fixes it. For VarDumper but also other places where we have logic to display them. Commits ------- 1c1818b [VarDumper] fix dump of closures created from callables
the new behavior is tested in VarDumper, but not in other places |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 11, 2018
…ass usage to describe callables (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29054 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A `\ReflectionFunctionAbstract::getClosureScopeClass` returns a `\ReflectionClass` instance, not the class name. Before this patch: ```diff --- Expected +++ Actual @@ @@ -'Symfony\Component\EventDispatcher\Tests\Debug\FooListener::listen' +'Class [ <user> class Symfony\Component\EventDispatcher\Tests\Debug\FooListener ] { + @@ [...]/src/Symfony/Component/EventDispatcher/Tests/Debug/WrappedListenerTest.php 28-33 + + - Constants [0] { + } + + - Static properties [0] { + } + + - Static methods [0] { + } + + - Properties [0] { + } + + - Methods [1] { + Method [ <user> public method listen ] { + @@ [...]/src/Symfony/Component/EventDispatcher/Tests/Debug/WrappedListenerTest.php 30 - 32 + } + } +} +::listen' ``` Commits ------- 61e4592 [Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing displaying full information about closures created using
ReflectionMethod::getClosure()
orClosure::fromCallable()
.This PR fixes it. For VarDumper but also other places where we have logic to display them.