[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options #29126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Nov 7, 2018
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28984 |
| License | MIT |
| Doc PR | todo |
…ons" This reverts commit 9f60ff8.
nicolas-grekas
previously approved these changes
Nov 7, 2018
…and server:run" This reverts commit 31b5615.
b7d4389 to
3ad8da9
Compare
|
I have a new proposal here: let's keep the deprecation in place! |
|
Closing in favor of #29154. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 10, 2018
…pplication::bootstrapEnv() (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28984, #29126 | License | MIT | Doc PR | todo Replaces #29126. Commits ------- bbd5682 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()
nicolas-grekas
added a commit
that referenced
this pull request
Nov 14, 2018
…-env and --no-debug console options (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options This reverts commit 9f60ff8. This reverts commit 31b5615. | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28984 | License | MIT | Doc PR | - Working on recipes with @weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it. Same as #29126, reverts #28745 and #28653 Commits ------- 443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.