[Routing] generate(null) should throw an exception #29191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 12, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28634 |
| License | MIT |
| Doc PR | - |
stof
approved these changes
Nov 12, 2018
xabbuh
approved these changes
Nov 12, 2018
|
Should this be considered a BC break? I mean we currently don’t have a type hint here, so the behavior is changed. |
OskarStark
approved these changes
Nov 12, 2018
|
3.4 throws already, that's a bug :) |
|
In this case... 👍🏻😉 |
OskarStark
approved these changes
Nov 12, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2018
…s-grekas) This PR was merged into the 4.1 branch. Discussion ---------- [Routing] generate(null) should throw an exception | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28634 | License | MIT | Doc PR | - Commits ------- 710aafb [Routing] generate(null) should throw an exception
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.