[FrameworkBundle] xliff-version option to translation update command #29850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jan 11, 2019
src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
Outdated
Show resolved
Hide resolved
javiereguiluz
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
I wondered if we should validate the given version somehow ... but in addition to complicating things, not doing that gives more flexibility for edge-cases where developers may need to use a non-standard looking version. So I think the proposed changes are enough. Thanks!
fabpot
approved these changes
Jan 14, 2019
|
@javiereguiluz the XliffDumper already validates the version. |
6c1d13d to
e908bed
Compare
e908bed to
4ec28bd
Compare
|
Thank you @andrewwro. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 24, 2019
…update command (andrewwro) This PR was squashed before being merged into the 4.3-dev branch (closes #29850). Discussion ---------- [FrameworkBundle] xliff-version option to translation update command | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | no <!-- please add some, will be required by reviewers --> | License | MIT New 'version' option added to xliff translation update command. Currently xliff version is hardcoded to 1.2. Commits ------- 4ec28bd [FrameworkBundle] xliff-version option to translation update command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New 'version' option added to xliff translation update command. Currently xliff version is hardcoded to 1.2.