Skip to content

[Mime] Add a set of default content-types for some extensions #29936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jan 20, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Some extensions have many possible content-types. This PR forces the first (preferred) content type for some extensions (the preset comes from Swiftmailer).

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 24, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with two minor comments that'd be nice fixing.)

@fabpot fabpot force-pushed the mime-types-preferences branch from 26b6d78 to 2912796 Compare January 27, 2019 10:25
@fabpot fabpot force-pushed the mime-types-preferences branch from 2912796 to 37065d4 Compare January 27, 2019 10:27
@fabpot fabpot merged commit 37065d4 into symfony:master Jan 27, 2019
fabpot added a commit that referenced this pull request Jan 27, 2019
…ensions (fabpot)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Mime] Add a set of default content-types for some extensions

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Some extensions have many possible content-types. This PR forces the first (preferred) content type for some extensions (the preset comes from Swiftmailer).

Commits
-------

37065d4 [Mime] added a set of default content-types for some extensions
@fabpot fabpot deleted the mime-types-preferences branch March 4, 2019 11:08
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants