Fix format strings for deprecation notices #30004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `%c` conversion specifier expects an integer (the value of the byte to print) Detected via static analysis
xabbuh
approved these changes
Jan 28, 2019
OskarStark
approved these changes
Jan 28, 2019
|
Thank you @TysonAndre. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 28, 2019
This PR was merged into the 4.2 branch. Discussion ---------- Fix format strings for deprecation notices | Q | A | ------------- | --- | Branch? | master for features / 3.4 up to 4.2 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | The `%c` conversion specifier expects an integer (the value of the byte to print). To produce a literal `%`, `%%` should be used. Detected via static analysis Commits ------- 2e00dfb Fix format strings for deprecation notices
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
%cconversion specifier expects an integer(the value of the byte to print). To produce a literal
%,%%should be used.Detected via static analysis