[Cache] fix pruning pdo cache for vendors that throw on execute #30050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 31, 2019
|
Shouldnt be a test added/updated? |
|
in honestly, i did not check for existing tests as previous fixes for this issue (linked above) added no tests. |
|
Maybe this is the reason why this bug occurred afterwards 🙃 |
|
This is already tested - just not on mysql - and we're not going to add a multi-DB infra for this :) |
|
Thank you @bendavies. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 1, 2019
…ecute (bendavies) This PR was merged into the 4.2 branch. Discussion ---------- [Cache] fix pruning pdo cache for vendors that throw on execute | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no > | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This additionally fixes pruning of the PdoAdapter when the table does not exist. Similar to #29900 #30005 and f419851 Commits ------- 14b9fa5 fix pruning pdo cache for vendors that throw on execute
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally fixes pruning of the PdoAdapter when the table does not exist.
Similar to #29900 #30005 and f419851