[Security] undeprecate the RoleHierarchyInterface #30388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e147a56 to
8cc37de
Compare
chalasr
reviewed
Feb 27, 2019
src/Symfony/Component/Security/Core/Role/RoleHierarchyInterface.php
Outdated
Show resolved
Hide resolved
22f39c7 to
fb602ce
Compare
src/Symfony/Component/Security/Core/Role/RoleHierarchyInterface.php
Outdated
Show resolved
Hide resolved
Instead of deprecating the interface it is sufficient to deprecate its getReachableRoles() method and add a new getReachableRoleNames() method in Symfony 5.
chalasr
approved these changes
Mar 23, 2019
fabpot
approved these changes
Mar 23, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2019
…buh) This PR was merged into the 4.3-dev branch. Discussion ---------- [Security] undeprecate the RoleHierarchyInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22048 (comment) | License | MIT | Doc PR | Instead of deprecating the interface it is sufficient to deprecate its getReachableRoles() method and add a new getReachableRoleNames() method in Symfony 5. Commits ------- 2d3f2b7 undeprecate the RoleHierarchyInterface
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…rface (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Fixed Guard Listener usage of RoleHierarchyInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | EUFOSSA related to #30388 Commits ------- a12b359 [Workflow] Fixed Guard Listener usage of RoleHierarchyInterface
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deprecating the interface it is sufficient to deprecate its
getReachableRoles() method and add a new getReachableRoleNames() method
in Symfony 5.