[Routing] Fix: annotation loader ignores method's default values #30825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that 4.1 is EOLed, this is for 4.2. |
nicolas-grekas
approved these changes
Apr 3, 2019
|
@nicolas-grekas, thank you for the help! |
fabpot
approved these changes
Apr 3, 2019
|
Thank you @voronkovich. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2019
…values (voronkovich) This PR was merged into the 4.2 branch. Discussion ---------- [Routing] Fix: annotation loader ignores method's default values | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no In some cases annotation loader ignores method param's default values. For example this code won't work as expected: ```php /** * @route("/hello/{name<\w++>}", methods="GET", name="hello") */ public function hello(Request $request, string $name = 'World'): Response { // If you try to open "/hello" path an exception (No route found for "GET /hello") will be thrown. return $this->json([ 'hello' => \sprintf('Hello, %s!', $name), ]); } ``` Commits ------- 9b37793 [Routing] Fix: annotation loader ignores method's default values
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases annotation loader ignores method param's default values.
For example this code won't work as expected: