-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Cache] Added command for list all available cache pools #31021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Nyholm
commented
Apr 8, 2019
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | symfony/symfony-docs#9782 |
License | MIT |
Doc PR |
chalasr
reviewed
Apr 8, 2019
src/Symfony/Bundle/FrameworkBundle/Command/CachePoolListCommand.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 8, 2019
src/Symfony/Component/HttpKernel/CacheClearer/Psr6CacheClearer.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 8, 2019
src/Symfony/Component/Cache/DependencyInjection/CachePoolPass.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test case would be cool though (something similar to CachePoolClearCommandTest)
A test is added. Thank you for the reviews |
c337b8f
to
5c210e6
Compare
Thank you @Nyholm. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 10, 2019
…ls (Nyholm) This PR was squashed before being merged into the 4.3-dev branch (closes #31021). Discussion ---------- [Cache] Added command for list all available cache pools | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#9782 | License | MIT | Doc PR | Commits ------- 5c210e6 [Cache] Added command for list all available cache pools
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 10, 2019
This PR was merged into the master branch. Discussion ---------- [Cache] Show how to list all available pools This is documentation for symfony/symfony#31021 This will fix #9782 Commits ------- e1636aa Show how to list all available pools
Thank you for merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.