Skip to content

Fix name and phpdoc of ContainerBuilder::removeBindings #31173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2019
Merged

Fix name and phpdoc of ContainerBuilder::removeBindings #31173

merged 1 commit into from
Apr 27, 2019

Conversation

teohhanhui
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29944 (comment)
License MIT
Doc PR N/A

@teohhanhui teohhanhui mentioned this pull request Apr 18, 2019
Merged
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 18, 2019
@teohhanhui teohhanhui changed the title Fix phpoc param type for ContainerBuilder::addRemovedBindingIds Fix name and phpdoc of ContainerBuilder::addRemovedBindingId Apr 18, 2019
@teohhanhui
Copy link
Contributor Author

The method name was also wrong. It's okay to change because it's @internal.

@teohhanhui teohhanhui changed the title Fix name and phpdoc of ContainerBuilder::addRemovedBindingId Fix name and phpdoc of ContainerBuilder::removeBindings Apr 20, 2019
@teohhanhui teohhanhui mentioned this pull request Apr 20, 2019
Merged
@fabpot
Copy link
Member

fabpot commented Apr 22, 2019

Even if the method is marked as internal, we won't rename the method in 3.4 as this is not a bug fix. So, the phpdoc can be merged in 3.4, but the rest should be done in master.

@nicolas-grekas
Copy link
Member

These methods have been released for the 1st time 10 days ago, see #29944
I think we can/should change them in 3.4.

@nicolas-grekas
Copy link
Member

Thank you @teohhanhui.

@nicolas-grekas nicolas-grekas merged commit c93194d into symfony:3.4 Apr 27, 2019
nicolas-grekas added a commit that referenced this pull request Apr 27, 2019
@nicolas-grekas
minor #31173 Fix name and phpdoc of ContainerBuilder::removeBindings …
eaba717 
…(teohhanhui)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix name and phpdoc of ContainerBuilder::removeBindings

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29944 (comment)
| License       | MIT
| Doc PR        | N/A

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

c93194d Fix name and phpdoc of ContainerBuilder::removeBindings
@teohhanhui teohhanhui deleted the patch-3 branch April 27, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof left review comments

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@teohhanhui @fabpot @nicolas-grekas @stof @OskarStark @xabbuh @carsonbot