Skip to content

[TwigBundle] Removed capability to load Twig template from legacy directories #31667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

[TwigBundle] Removed capability to load Twig template from legacy directories #31667

merged 1 commit into from
May 30, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented May 28, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Ref #28891

@yceruto yceruto force-pushed the rm_twig_legacy_path branch from 0284b79 to 5417fb2 Compare May 28, 2019 21:58
@yceruto
Copy link
Member Author

yceruto commented May 28, 2019

(AppVeyor failure unrelated)

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone May 29, 2019
@yceruto yceruto mentioned this pull request May 29, 2019
Merged
@yceruto yceruto force-pushed the rm_twig_legacy_path branch from 5417fb2 to 1e12818 Compare May 29, 2019 16:48
@yceruto yceruto requested a review from xabbuh as a code owner May 29, 2019 16:48
@yceruto
Copy link
Member Author

yceruto commented May 29, 2019

Waiting for #31688

Status: Needs Work

@yceruto yceruto force-pushed the rm_twig_legacy_path branch from 1e12818 to 5fceec7 Compare May 29, 2019 17:05
Tobion added a commit that referenced this pull request May 29, 2019
@Tobion
minor #31688 [TwigBridge] Swapped $rootDir and $fileLinkFormatter arg…
ea8c054 
…uments in DebugCommand (yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBridge] Swapped $rootDir and $fileLinkFormatter arguments in DebugCommand

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is necessary to remove the `$rootDir` in 5.0, see #31667

Commits
-------

beca864 exchanged $rootDir and $fileLinkFormatter arguments in DebugCommand
symfony-splitter pushed a commit to symfony/twig-bridge that referenced this pull request May 29, 2019
@Tobion
minor #31688 [TwigBridge] Swapped $rootDir and $fileLinkFormatter arg…
879ee98 
…uments in DebugCommand (yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBridge] Swapped $rootDir and $fileLinkFormatter arguments in DebugCommand

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is necessary to remove the `$rootDir` in 5.0, see symfony/symfony#31667

Commits
-------

beca8642ca exchanged $rootDir and $fileLinkFormatter arguments in DebugCommand
@yceruto yceruto force-pushed the rm_twig_legacy_path branch from 5fceec7 to 904ff1c Compare May 29, 2019 22:54
@yceruto yceruto force-pushed the rm_twig_legacy_path branch from 904ff1c to 4b6752b Compare May 30, 2019 14:25
@yceruto
Copy link
Member Author

yceruto commented May 30, 2019

Rebased and ready!

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit 4b6752b into symfony:master May 30, 2019
nicolas-grekas added a commit that referenced this pull request May 30, 2019
@nicolas-grekas
minor #31667 [TwigBundle] Removed capability to load Twig template fr…
6b74938 
…om legacy directories (yceruto)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[TwigBundle] Removed capability to load Twig template from legacy directories

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Ref #28891

Commits
-------

4b6752b Removed capability to load Twig template from legacy directories
@yceruto yceruto deleted the rm_twig_legacy_path branch May 30, 2019 15:16
@Tobion Tobion mentioned this pull request Jun 3, 2019
Merged
fabpot added a commit that referenced this pull request Jun 5, 2019
@fabpot
minor #31823 [TwigBundle] remove legacy template dirs from iterator (…
455a1aa 
…Tobion)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[TwigBundle] remove legacy template dirs from iterator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | yes
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Some leftovers from #31667

Commits
-------

d1137f9 [TwigBundle] remove legacy template dirs from iterator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas requested changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed TwigBundle
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yceruto @nicolas-grekas @xabbuh @carsonbot