[Console] Remove deprecated code #31689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
May 29, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
491520a to
3dfeb69
Compare
prisis
reviewed
May 29, 2019
04c38c0 to
d47e984
Compare
a90e84c to
b2e76fa
Compare
|
Failing |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
…asr) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Make DebugHandlersListener internal | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Required to remove the legacy `Event` argument type declaration from its `configure()` method in 5.0. Unlocks #31689 Commits ------- 1a8db29 [HttpKernel] Make DebugHandlersListener internal
b2e76fa to
317b80f
Compare
|
Now green thanks to #31734 |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] Remove deprecated code | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 317b80f [Console] Remove deprecated features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.