From 64a2ee011755c00314aebf6f57d384616a57802c Mon Sep 17 00:00:00 2001 From: Amrouche Hamza Date: Wed, 29 May 2019 19:11:21 +0200 Subject: [PATCH] [HttpKernel] The methods of the deprecated event should be final --- UPGRADE-4.4.md | 9 +++++++++ src/Symfony/Component/HttpKernel/CHANGELOG.md | 9 +++++++++ .../HttpKernel/Event/FilterControllerArgumentsEvent.php | 2 ++ .../Component/HttpKernel/Event/FilterControllerEvent.php | 2 ++ .../Component/HttpKernel/Event/FilterResponseEvent.php | 2 ++ .../HttpKernel/Event/GetResponseForExceptionEvent.php | 2 ++ .../Component/HttpKernel/Event/PostResponseEvent.php | 2 ++ 7 files changed, 28 insertions(+) diff --git a/UPGRADE-4.4.md b/UPGRADE-4.4.md index ec1852e3e468e..b930639bb2329 100644 --- a/UPGRADE-4.4.md +++ b/UPGRADE-4.4.md @@ -19,3 +19,12 @@ DependencyInjection my_service: factory: ['@factory_service', method] ``` + +HttpKernel +---------- + +* The method `FilterControllerArgumentsEvent::getArguments()` marked final. +* The method `FilterControllerEvent::getController()` marked final. +* The method `FilterResponseEvent::getResponse()` marked final. +* The method `GetResponseForExceptionEvent::getException()` marked final. +* The method `PostResponseEvent::getResponse()` marked final. \ No newline at end of file diff --git a/src/Symfony/Component/HttpKernel/CHANGELOG.md b/src/Symfony/Component/HttpKernel/CHANGELOG.md index b1a5f5101b41d..3873937decbfe 100644 --- a/src/Symfony/Component/HttpKernel/CHANGELOG.md +++ b/src/Symfony/Component/HttpKernel/CHANGELOG.md @@ -1,6 +1,15 @@ CHANGELOG ========= +4.4.0 +----- + +* The method `FilterControllerArgumentsEvent::getArguments()` has been made final +* The method `FilterControllerEvent::getController()` has been made final +* The method `FilterResponseEvent::getResponse()` has been made final +* The method `GetResponseForExceptionEvent::getException()` has been made final +* The method `PostResponseEvent::getResponse()` has been made final + 4.3.0 ----- diff --git a/src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php b/src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php index ac8e0263cabf3..d1c0abb1ed1b3 100644 --- a/src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php +++ b/src/Symfony/Component/HttpKernel/Event/FilterControllerArgumentsEvent.php @@ -29,6 +29,8 @@ public function __construct(HttpKernelInterface $kernel, callable $controller, a } /** + * @final since Symfony 4.4 + * * @return array */ public function getArguments() diff --git a/src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php b/src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php index 74fa681f80984..636be1146016d 100644 --- a/src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php +++ b/src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php @@ -31,6 +31,8 @@ public function __construct(HttpKernelInterface $kernel, callable $controller, R /** * Returns the current controller. * + * @final since Symfony 4.4 + * * @return callable */ public function getController() diff --git a/src/Symfony/Component/HttpKernel/Event/FilterResponseEvent.php b/src/Symfony/Component/HttpKernel/Event/FilterResponseEvent.php index eaa2e8256540e..a67e73ecef719 100644 --- a/src/Symfony/Component/HttpKernel/Event/FilterResponseEvent.php +++ b/src/Symfony/Component/HttpKernel/Event/FilterResponseEvent.php @@ -32,6 +32,8 @@ public function __construct(HttpKernelInterface $kernel, Request $request, int $ /** * Returns the current response object. * + * @final since Symfony 4.4 + * * @return Response */ public function getResponse() diff --git a/src/Symfony/Component/HttpKernel/Event/GetResponseForExceptionEvent.php b/src/Symfony/Component/HttpKernel/Event/GetResponseForExceptionEvent.php index 3476c7e62a0cc..e09ad5ba64575 100644 --- a/src/Symfony/Component/HttpKernel/Event/GetResponseForExceptionEvent.php +++ b/src/Symfony/Component/HttpKernel/Event/GetResponseForExceptionEvent.php @@ -41,6 +41,8 @@ public function __construct(HttpKernelInterface $kernel, Request $request, int $ /** * Returns the thrown exception. * + * @final since Symfony 4.4 + * * @return \Exception The thrown exception */ public function getException() diff --git a/src/Symfony/Component/HttpKernel/Event/PostResponseEvent.php b/src/Symfony/Component/HttpKernel/Event/PostResponseEvent.php index b86bf07742412..cdb1fd17941bd 100644 --- a/src/Symfony/Component/HttpKernel/Event/PostResponseEvent.php +++ b/src/Symfony/Component/HttpKernel/Event/PostResponseEvent.php @@ -32,6 +32,8 @@ public function __construct(HttpKernelInterface $kernel, Request $request, Respo /** * Returns the response for which this event was thrown. * + * @final since Symfony 4.4 + * * @return Response */ public function getResponse()