Skip to content

[HttpKernel] Fix handling non-catchable fatal errors #31868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This reverts PR #27519 this commit 18c2dde,
reversing changes made to ac1189a.

Right now, the listener is skipped on fatal errors.

This reverts PR symfony#27519 this commit 18c2dde,
reversing changes made to ac1189a.
@nicolas-grekas nicolas-grekas force-pushed the debug-http-exceptions branch from 97e2f07 to a1619cc Compare June 5, 2019 11:34
@fabpot
Copy link
Member

fabpot commented Jun 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit a1619cc into symfony:4.2 Jun 5, 2019
fabpot added a commit that referenced this pull request Jun 5, 2019
…las-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[HttpKernel] Fix handling non-catchable fatal errors

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This reverts PR #27519 this commit 18c2dde,
reversing changes made to ac1189a.

Right now, the listener is skipped on fatal errors.

Commits
-------

a1619cc [HttpKernel] Fix handling non-catchable fatal errors
@nicolas-grekas nicolas-grekas deleted the debug-http-exceptions branch June 5, 2019 14:41
@fabpot fabpot mentioned this pull request Jun 6, 2019
@fabpot fabpot mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants