[Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional) #31923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
commented
Jun 7, 2019
| @@ -34,12 +34,12 @@ class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, C | |||
| ]; | |||
|
|
|||
| /** | |||
| * @var MimeTypeGuesserInterface | |||
| * @var MimeTypeGuesserInterface|null | |||
There was a problem hiding this comment.
Should be fixed on 3.4, see #31922
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2019
…guesser is optional) (ogizanagi) This PR was merged into the 4.3 branch. Discussion ---------- [Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional) | Q | A | ------------- | --- | Branch? | 4.3 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Relates to #31771 (comment) : The deprecation isn't fundamentally wrong, but if none of the Mime nor HttpFoundation components are installed, the DataUriNormalizer can be used, and the MIME type used will always be `'application/octet-stream'` https://github.com/symfony/symfony/blob/9691519ca46511005bc701ca93c2973923952034/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php#L39-L46 https://github.com/symfony/symfony/blob/9691519ca46511005bc701ca93c2973923952034/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php#L135-L139 So this completes the deprecation message, as well as allowing `null` again when no default MIME type guesser is available at all. Commits ------- 2740bd1 [Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #31771 (comment) :
The deprecation isn't fundamentally wrong, but if none of the Mime nor HttpFoundation components are installed, the DataUriNormalizer can be used, and the MIME type used will always be
'application/octet-stream'symfony/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
Lines 39 to 46 in 9691519
symfony/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
Lines 135 to 139 in 9691519
So this completes the deprecation message, as well as allowing
nullagain when no default MIME type guesser is available at all.