[Messenger] fix AMQP delay queue to be per exchange #32052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70dcc96 to
f4efec0
Compare
weaverryan
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Obviously, this stuff is complex. Assuming you've tested in IRL @Tobion, it's a +1 for me - the code & bug make perfect sense.
fabpot
approved these changes
Jun 17, 2019
f4efec0 to
5bc3364
Compare
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jun 17, 2019
This PR was squashed before being merged into the 4.3 branch (closes #32052). Discussion ---------- [Messenger] fix AMQP delay queue to be per exchange | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32050 | License | MIT | Doc PR | this makes the delay/retry work when having several exchanges or renaming your exchange. also the delay setup did not declare the target exchange. so if you only do delayed messages for a connection, auto-setup forgot to actually create the target exchange. Commits ------- 5bc3364 [Messenger] fix AMQP delay queue to be per exchange
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the delay/retry work when having several exchanges or renaming your exchange.
also the delay setup did not declare the target exchange. so if you only do delayed messages for a connection, auto-setup forgot to actually create the target exchange.