[HttpClient] fix dealing with 1xx informational responses #32141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 26, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
…(nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] fix dealing with 1xx informational responses | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I never had a look at 1xx status codes until today. This PR fixes reading them when using curl. If one wonders: - `NativeHttpClient` uses `fopen()`, which skips informational parts as allowed by the HTTP spec and doesn't give any way to access their response headers. - `CurlHttpClient` allows reading informational responses using the progress callback or via the getInfo() method. That's the way if you need to implement e.g. HTTP 103 early hints. Commits ------- 412411d [HttpClient] fix dealing with 1xx informational responses
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never had a look at 1xx status codes until today.
This PR fixes reading them when using curl.
If one wonders:
NativeHttpClientusesfopen(), which skips informational parts as allowed by the HTTP spec and doesn't give any way to access their response headers.CurlHttpClientallows reading informational responses using the progress callback or via the getInfo() method. That's the way if you need to implement e.g. HTTP 103 early hints.