[Cache] Add argument $prefix to AdapterInterface::clear() #32284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jun 29, 2019
| $prefix = 0 < \func_num_args() ? (string) func_get_arg(0) : ''; | ||
|
|
||
| if ($this->pool instanceof AdapterInterface) { | ||
| return $this->pool->clear($this->namespace.$prefix); |
There was a problem hiding this comment.
here is the targetted behavior of this new argument
ec84446 to
ad6f6cf
Compare
fabpot
approved these changes
Jul 8, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…r() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Add argument $prefix to AdapterInterface::clear() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR allows clearing `AdapterInterface` implementations by prefix of keys. The goal is to fix an edge case situation in `ProxyAdapter`: right now, when one calls `->clear()` on a proxy adapter that is configured to add a prefix to all the keys passed to the decorated pool, we clear it all; while only the subset that starts with the prefix should be. Since `AdapterInterface` is an "internal" interface (ie its purpose is to create compatible implementations - *NOT* to be type-hinted for), this is not really a user-facing change. /cc @Nyholm, this came out after we talked about proxified chain pools Commits ------- ad6f6cf [Cache] Add argument $prefix to AdapterInterface::clear()
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows clearing
AdapterInterfaceimplementations by prefix of keys. The goal is to fix an edge case situation inProxyAdapter: right now, when one calls->clear()on a proxy adapter that is configured to add a prefix to all the keys passed to the decorated pool, we clear it all; while only the subset that starts with the prefix should be.Since
AdapterInterfaceis an "internal" interface (ie its purpose is to create compatible implementations - NOT to be type-hinted for), this is not really a user-facing change./cc @Nyholm, this came out after we talked about proxified chain pools