Skip to content

[Lock][Console] bump lock requirement in console #32450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jul 9, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR not needed

Fix test of the console component, by bumping the lock requirement

@Simperfit Simperfit force-pushed the lock/fix-test-console branch from 7bf15ce to 41de633 Compare July 9, 2019 07:02
@Simperfit Simperfit changed the title [Lock][Console] fix test [Lock][Console] bump lock requirement in console Jul 9, 2019
@Simperfit
Copy link
Contributor Author

test high will be fixed when 4.4 will be merged in master

@fabpot
Copy link
Member

fabpot commented Jul 9, 2019

Thank you @Simperfit.

@fabpot fabpot merged commit 41de633 into symfony:4.4 Jul 9, 2019
fabpot added a commit that referenced this pull request Jul 9, 2019
…fit)

This PR was merged into the 4.4 branch.

Discussion
----------

[Lock][Console] bump lock requirement in console

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | not needed <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Fix test of the console component, by bumping the lock requirement

Commits
-------

41de633 [Lock][Console] bump lock requirement in console
@Simperfit Simperfit deleted the lock/fix-test-console branch July 9, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants